8000 test: the session-request helper uses session_effective_egress, and the task-only network-key test says what it proves · Issue #3406 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

test: the session-request helper uses session_effective_egress, and the task-only network-key test says what it proves #3406

Open

Description

@norrietaylor

Residual of #3394 (D3144, merged as eb191b5c), from @bryan-minimal's review at 83affb04. Epic #2236.

1. The session-request test helper still uses the old egress merge

crates/minimal/src/tests.rs:14748 (and its use near line 18698) builds a session request "with the functions activate_box calls", but it still calls the old merge (effective_egress), not session_effective_egress. A later test of --network none with project egress would build a request that the real start refuses. Change the call to session_effective_egress, so the helper builds what activate_box builds.

2. The proof and the test name overclaim

#3394's proof says a minimal.toml with two session entries and a network key only in [tasks.build] "starts a session". It does not. The egress read no longer refuses that file, but every start then runs session_loadout_mode (create.rs:1247, called at 3477) and session_box_entry (create.rs:1531, called at 3533). Both call pick_session_entry(..)? when no entry is named, so the start still exits 2 with the "no default" text, one step later. The narrowing removes a redundant refusal and changes no outcome.

Rename network_key_only_in_task_does_not_refuse_session_pick to say what it proves: the egress read does not refuse a file whose only network key is in a task. Its doc comment should say that such a start still needs a decided session entry.


This is a residual of epic #2236 (BOX).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority:nice-to-haveNice to have. Applied by the inbox-route classifier or a human.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0