Repository navigation
fix(minimal): renaming a running host_ip box retires its VM-host egress (min box rename, min session rename) #3011
Description
Found while reviewing BCLI T22 (#2907, PR #3008).
What happens. Renaming a running host_ip box on a VM-backed host moves its name hold to the new name, and also retires the box's egress rules on the VM host, while the box keeps running.
Why. cmd_box_rename (crates/minimal/src/cmd/boxes/lifecycle.rs, in PR #3008) and min session rename (crates/minimal/src/cmd/session.rs ~739, on main) both call release_held_box_name(.., None). With no box_addresses, that function always calls retire_host_ip_box_with_vm_host(id) (crates/minimal/src/vm_host.rs ~213–226, retire at ~575, NET-085). That call is right for a box that ends, and wrong for a rename.
Fix direction. A rename moves only the name hold: release the old name and hold the new one (hold_box_name_with_vm_host(.., false)) without retiring the box's host_ip egress. Add a test that renames a running host_ip box and checks its egress rules are still held.
Covers both min box rename and min session rename.
Activity