8000 Criteria of branch promotion · Issue #190 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

Criteria of branch promotion #190

Closed
Closed

Description

@norrietaylor

Migrated from Notion on 2026-05-07

Workflow

  • Create PR to next
  • PR’s build is green
  • Cron job rebase and the PR against next, and aggregate it with other open and green PRs to unstable
  • The package version must be at least 7 days old since release
  • PR is approved by someone other than the author
  • PR is merged into next
  • Create PR to stable
  • The PR’s build is green
  • The package version must be at least 7 days old since release
  • The PR dwells in next for 7 days. This gives the community an opportunity to provide feedback about the package
  • PR is approved
  • PR is merged into stable

Promotion to next

  • PRs are based on next ;
  • Manual approval from a Minimal staff other than the author is required;
  • Smoke test coverage for all major functionality is required;
    • These are standalone tests in buildspec that meaningfully test functionalities of the package. The package’s native tests (ie. make test) cannot be used for this purpose.
  • Version of the package must by >7 days.

Promotion to stable / main

  • Inclusive of all criteria used for promotion to next ;
    • This requires a second PR approval
  • Delve time >7 days;
  • No negative community feedback.

Other Promotion Rules

  • Trivial updates
    • Trivial is defined as: no new features, no breaking changes. The judgement of this will need to be automated.
    • 6D39
    • Human approval based on green build in PR. No manual package execution / functional validation required.
    • Mechanism: tag pr as #trivial
  • Non-trivial CVE / vulnerability
    • Goes through all validation criteria in next and stable
    • Manually expedited
  • Any branch that are user facing must have binary ready in the cache
    • Need a mechanism to keep caches up to date for next and stable

Acceptance Criteria

  • User is able to use next and stable as part of the [upstream] definition without the CLI throwing errors
  • Users are not waiting for packages to build when executing tasks while on next or stable branch, unless they specify rebuild flags.
  • Binaries from the next branch must be ≥7 days old since the release of the corresponding package version
    • The exception to this is in the case of non-trivial CVE / vulnerability.
  • Binaries from the stable branch must be ≥14 days old since the release of the corresponding package version
    • The exception to this is in the case of non-trivial CVE / vulnerability.

Sub-tasks

Activity

  1. norrietaylor commented on Jun 1, 2026

    @norrietaylor
    MemberAuthor

    Closing - bad routing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0