8000 fix(minimal): register own-ip boxes on macOS without an explicit --provider · Issue #1816 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(minimal): register own-ip boxes on macOS without an explicit --provider #1816

Closed

Description

@norrietaylor

Problem

On macOS, a default own_ip activation never registers its box with the VM host's table.

register_box_for_activation (crates/minimal/src/cmd/session.rs) returns None unless
global.use_minvmd() is true. GlobalArgs::use_minvmd() (crates/minimal/src/cli.rs) is true
only when --provider local-minvmd is passed explicitly. On macOS minvmd is the only backend,
so min session activate without the flag still runs the box in the VM, but unregistered: its
frames run unattributed.

Today the gate's announced interim hides this. Once the gate's per-box default fails closed
(#1790), every macOS own-IP box created
without the explicit flag is refused.

Evidence

The macOS e2e job for #1810 at b3aa8618
(job 110908314383):
every VM box (100.64.0.2 through .6) logs egress-unregistered-source, and the BEP
pre-screen resets box A with "reset a connection from a source with no registered row". The
macOS lane runs session-e2e.sh with no E2E_MINIMAL_ARGS; the KVM lane passes
--provider local-minvmd and registers.

Done when

  • use_minvmd() (or the registration guard) is true whenever the resolved backend is minvmd,
    including the macOS default with no --provider.
  • A test proves a macOS default own_ip activation registers its box.

Activity

  1. norrietaylor commented on Oct 5, 2026

    @norrietaylor
    MemberAuthor

    Fixed by T78 (#1837) in #1852. register_box_for_activation now keys on the resolved provider kind (daemon_provider_kind), not use_minvmd(), and fails the activation rather than running unregistered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0