8000 vroom should have some Python unit tests · Issue #63 · google/vroom · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Aug 15, 2026. It is now read-only.
This repository was archived by the owner on Aug 15, 2026. It is now read-only.

vroom should have some Python unit tests #63

Open

Description

@malcolmr

See discussion in #62. Some of our Python code has doctests (which I suspect don't get run), but most of it is untested except at the integration level (by running vroom itself). We should have more Python-level unittests, and a simple way to run all the tests.

Activity

  1. dbarnett commented on Oct 23, 2014

    @dbarnett
    Contributor

    TBD whether these tests should depend on having vim installed or mock it out (or both). Vim has enough quirks to it that I'd rather include real vim in the tests instead of emulating all its quirks.

    For doctests, we'll have to deal with http://bugs.python.org/issue22710. doctest for python3 is kind of dumb and pedantic.

  2. malcolmr commented on Oct 24, 2014

    @malcolmr
    MemberAuthor

    I'd certainly mock out vim in the unit tests (though actually, most of the code we have doesn't actually have dependencies): the vroom tests effectively feature as integration tests.

    For doctests, I'd actually be happier migrating them to unittest-style tests anyway: I don't find the tests in e.g. actions.py that easy to read.

  3. dbarnett commented on Oct 24, 2014

    @dbarnett
    Contributor

    Yeah, doctests should be primarily documentation. I agree our doctests are being abused as tests and way too exhaustive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0