8000 Detect neovim vs. vim automatically · Issue #132 · google/vroom · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Aug 15, 2026. It is now read-only.
This repository was archived by the owner on Aug 15, 2026. It is now read-only.

Detect neovim vs. vim automatically #132

Open

Description

@dbarnett

Currently if you run vroom it tries to invoke vim classic as 'vim', or if you pass the --neovim option it tries to invoke neovim as 'nvim'. This gets annoying in a few ways:

  • It gets very confused for users who alias vim to neovim on their systems
  • It gives you no way to override the vim/nvim command to run
  • In error scenarios it gives really cryptic error output since it can't infer any context about how the target vim instance is supposed to work

It would be nice to generalize that and add inference so that you have more control over which vim executable it's invoking and it can more automagically figure out which options to pass to whichever vim variant it's pointed at.

Activity

  1. dbarnett commented on Aug 28, 2024

    @dbarnett
    ContributorAuthor

    FYI I have the improvements for this implemented in https://github.com/dbarnett/vroom/tree/detect_vim, but they're stacked on top of #133 so I'll wait to send a PR until that one's merged.

  2. snu5mumr1k commented on Aug 29, 2024

    @snu5mumr1k
    Contributor

    I would like to re-word this issue. Something like 'Allow configuration of the path to vim/nvim executable'. And a 59BF s part of what needs to be done improve on the errors quality.

    The root cause for it is not that we don't do things automatically, but that we use a command name instead of a file and don't allow the overwrite.

    For a testing framework making automatic choices is arguably less than desirable, as the mistake in configuration may survive unnoticed.

    A side note: I don't think aliases matter as much, because we don't use bash, but symlink collisions in path are very much an obvious problem.

  3. dbarnett commented on Aug 29, 2024

    @dbarnett
    ContributorAuthor

    That name SGTM. LMK if anything beyond the title sounds bad to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0