8000 Vroom fails in non-ANSI terminals with errors about missing color constants · Issue #112 · google/vroom · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Aug 15, 2026. It is now read-only.
This repository was archived by the owner on Aug 15, 2026. It is now read-only.

Vroom fails in non-ANSI terminals with errors about missing color constants #112

Closed

Description

@dbarnett

If I try to run vroom or its tests in a limited terminal that doesn't support ANSI color codes such as shelling out from gvim, it fails hard with errors about missing color constants:

:!vroom
Traceback (most recent call last):
  File "/home/dbarnett/.virtualenvs/py37/bin/vroom", line 5, in <module>
    import vroom.__main__
  File "/home/dbarnett/.virtualenvs/py37/lib/python3.7/site-packages/vroom/__main__.py", line 9, in <module>
    import vroom.output
  File "/home/dbarnett/.virtualenvs/py37/lib/python3.7/site-packages/vroom/output.py", line 27, in <module>
    STATUS.PASS: vroom.color.GREEN,
AttributeError: module 'vroom.color' has no attribute 'GREEN'

shell returned 1

The problem is that color.py silently falls back to COLORED=False mode if it can't invoke tput to configure those constants, but other parts of the code assume unconditionally that those constants will be defined.

Activity

  1. added a commit that references this issue on Jan 21, 2020
    ee12eb7
  2. self-assigned this
    on Jan 21, 2020
  3. added 2 commits that reference this issue on Jan 21, 2020
    f8b762c
    4c1b33f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    0