8000 System hijacks failing when using python 3.7 · Issue #110 · google/vroom · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Aug 15, 2026. It is now read-only.
This repository was archived by the owner on Aug 15, 2026. It is now read-only.

System hijacks failing when using python 3.7 #110

Closed
#111
Closed
System hijacks failing when using python 3.7#110
#111
Assignees
dbarnett
Labels
bug

Description

@malcolmr
malcolmr
opened on Dec 5, 2019

With Vim 8.1.2269, running Vroom over it's own tests fails with some odd doubled-up outputs for hijacked syscalls:

$ vroom examples/system.vroom
examples/system.vroom
FAILED on line 075: Expected "Testing." in verbatim mode.

Found:
1       Testing.echo Testing. <<<<

Failed command on line 075:
Testing.

Ran 5 tests in examples/system.vroom. 4 passing, 0 errored, 1 failed.
$ vroom examples/continuations.vroom
examples/continuations.vroom
FAILED on line 47: Expected "Captured" in verbatim mode.

Found:
1       CapturedCaptured <<<<

Failed command on line 47:
Captured

Ran 5 tests in examples/continuations.vroom. 4 passing, 0 errored, 1 failed.

I believe this is caused by a change in a recent version of Vim, probably sometime after 8.1.0875.

Activity

  1. malcolmr commented on Dec 5, 2019

    @malcolmr
    malcolmr
    on Dec 5, 2019
    MemberAuthor

    Actually, it doesn't look like this is Vim at all. I've built back to v7.4.2330, and I'm still seeing the same problem.

    I am using vroom 0.12.0, but that shouldn't matter here.

  2. malcolmr
    changed the title [-]System hijacks appear to be broken in recent Vim versions[/-] [+]System hijacks appear to be broken?[/+] on Dec 5, 2019

  3. malcolmr commented on Dec 5, 2019

    @malcolmr
    malcolmr
    on Dec 5, 2019
    MemberAuthor

    I wonder if this is actually recent versions of Python? (I have 3.7.5rc1 in the place it's failing).

  4. dbarnett
    changed the title [-]System hijacks appear to be broken?[/-] [+]System hijacks failing when using python 3.7[/+] on Jan 20, 2020

  5. dbarnett commented on Jan 20, 2020

    @dbarnett
    dbarnett
    on Jan 20, 2020
    Contributor

    Yep, I can repro and it fails on 3.7 but not on 3.5. Until the issue is tracked down and fixed, is it easy to just avoid python 3.7 for now in the places you're running into the failures, or not that simple?

  6. dbarnett commented on Jan 20, 2020

    @dbarnett
    dbarnett
    on Jan 20, 2020
    Contributor

    Possibly related: looks like doctests fail against python 3.7 as well, with a bunch of mismatch errors showing a trailing comma in the string representation of thrown exceptions. Example:

    ======================================================================
FAIL: Doctest: vroom.actions.ActionLine
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.7/doctest.py", line 2196, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for vroom.actions.ActionLine
  File "/home/dbarnett/projects/vroom/vroom/actions.py", line 63, in ActionLine

----------------------------------------------------------------------
File "/home/dbarnett/projects/vroom/vroom/actions.py", line 86, in vroom.actions.ActionLine
Failed example:
    try: ActionLine('  @nope')
    except vroom.ParseError as e: e
Expected:
    ParseError('Unrecognized directive "nope"',)
Got:
    ParseError('Unrecognized directive "nope"')

  7. dbarnett commented on Jan 20, 2020

    @dbarnett
    dbarnett
    on Jan 20, 2020
    Contributor

    Doctests issue was unrelated. I fixed it in 379eefc. Still looking into the syscalls.

  8. dbarnett commented on Jan 21, 2020

    @dbarnett
    dbarnett
    on Jan 21, 2020
    Contributor

    Looks like there was a strange behavior change in re.sub. In 3.5.4rc1:

    >>> re.sub('.*', 'Goodbye', 'Hello')
'Goodbye'

    In 3.7.5rc1:

    >>> re.sub('.*', 'Goodbye', 'Hello')
'GoodbyeGoodbye'

    Looks pretty simple to work around. We ought to also report upstream however that works, and should be a pretty simple unit test you could write in cpython to bisect when the behavior changed.

  9. dbarnett commented on Jan 21, 2020

    @dbarnett
    dbarnett
    on Jan 21, 2020
    Contributor

    I bisected it and tracked it down to https://bugs.python.org/issue32308. It's an intentional change, apparently. I can't wrap my head around why it would make sense, but it should be an easy workaround changing .* to ^.*$.

  10. dbarnett
    added a commit that references this issue on Jan 21, 2020

    Fix weirdly duplicated system hijack output on python 3.7

    01ce541
  11. dbarnett
    self-assigned this
    on Jan 21, 2020
  12. dbarnett
    added
    bug
    on Jan 21, 2020
  13. dbarnett
    closed this as completedin #111on Jan 21, 2020
  14. dbarnett
    added 2 commits that reference this issue on Jan 21, 2020

    Fix weirdly duplicated system hijack output on python 3.7

    86fd37f

    Bump version to 0.14.0

    4c1b33f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bug

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
    0