8000 Support for anchor tag - currently pollutes results · Issue #10 · funcool/bide · GitHub
[go: up one dir, main page]

Skip to content

Support for anchor tag - currently pollutes results #10

Open

Description

@ibothwell

Love the library. Very simple to use. Did run into issues with anchors. if they are on the path then they leak into the produced results.

(def routes [["/" :root] ["/:id" :root-with-id]])
(def my-router (r/router routes))
(r/match my-router "/") ; [:root nil nil]
(r/match my-router "/?a=1") ; [:root nil {:a "1"}]
(r/match my-router "/?a=1#asdf") ; [:root nil {:a "1#asdf"}]
(r/match my-router "/#asdf") ; [:root-with-id {:id "#asdf"} nil]
(r/match my-router "/my-id#asdf") ; [:root-with-id {:id "my-id#asdf"} nil]
(r/match my-router "/my-id?a=1#asdf") ; [:root-with-id {:id "my-id"} {:a "1#asdf"}]

Activity

  1. niwinz commented on May 28, 2017

    @niwinz
    Member

    A PR with a fix is welcome!

  2. kennyjwilli commented on Dec 18, 2018

    @kennyjwilli
    Contributor

    I am also interested in this. I assume we don't want to completely discard the anchor tag. @niwinz Where should the parsed anchor tag go in the result from match?

  3. kennyjwilli commented on Dec 18, 2018

    @kennyjwilli
    Contributor

    Also worth noting that the behavior I see is different than the behavior shown in this issue's description:

    (r/match (r/router [["/page1" :page1]])
             "/page1")
    => [:page1 nil nil]
    (r/match (r/router [["/page1" :page1]])
             "/page1#anchor")
    => nil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0