Repository navigation
CLA approvals fail when users add a period to the end of a sentence #13
Description
Bug Overview
Example: nginx/documentation#512
- There was a failure when the PR author signed the CLA, and added a period at the end of the sentence.
Expected Behavior
When the user signs the CLA in a reasonable way, the CLA test accepts it
Steps to Reproduce the Bug
- New user
- The user submits a PR
- The user signs the CLA, and adds a period to the end of the sentence.
Environment Details
GitHub UI
Additional Context
No response
Reacted by Copilot
Activity
alessfg commentedon May 8, 2025
There is not much we can do about this since from what I can tell, the signature message parameter does not allow a regex.
mjang commentedon May 8, 2025
Could we have two acceptable answers?
Unless there's someone from the F5/NGINX team on-site, this is a barrier to getting contributions. Yes, we can override the test failure, but that's not optimal.
alessfg commentedon May 8, 2025
The CLA action does not allow multiple answers sadly... We need to figure out if there's a way to do some level of regex handling before the proper CLA action runs.