8000 otel-cli --tp-carrier should flock() the file around writes · Issue #80 · equinix-labs/otel-cli · GitHub
[go: up one dir, main page]

Skip to content

otel-cli --tp-carrier should flock() the file around writes #80

Open

Description

@tobert

A frequent scripting trick is to forkbomb a bunch of things in parallel e.g. with xargs -P or plain old shell job control. When this happens, the child might want to do e.g. otel-cli exec --tp-carrier "$otel_carrier" curl -H "traceparent: $TRACEPARENT" https://my/api/v1/thing in the subprocesses. When this happens there is technically a race condition accessing the carrier file for read and write.

This probably isn't a big deal in practice because the file is so tiny, but we should do the right thing anyways.

https://github.com/gofrs/flock looks like a portable solution that probably won't blow up the dependency tree.

Activity

  1. self-assigned this
    on Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    0