8000 pull requests stalled · Issue #183 · equinix-labs/otel-cli · GitHub
[go: up one dir, main page]

Skip to content

pull requests stalled #183

Closed
Closed

Description

@tobert

I am considering asking the equinix-labs admins to disable the policy that requires someone not-me approve all pull requests. I've had some PRs sit a while because nobody's available to review. Mostly I've been reviewing my own PRs by waiting a while and coming back to them.

Alternatively, if a couple folks volunteer to be reviewers, I will figure out how to get you added to the list and we can continue with a normal PR process.

Activity

  1. self-assigned this
    on Apr 10, 2023
  2. garthk commented on May 3, 2023

    @garthk

    I'm attempting a dependency on otel-cli, and will be happy to review PRs if I succeed. That said I'd also be trying to facilitate custom distributions with extra processors and exporters, which might be more than you're up for.

  3. tobert commented on May 4, 2023

    @tobert
    ContributorAuthor
  4. garthk commented on May 5, 2023

    @garthk

    If we squint hard enough otel-cli kinda resembles the OpenTelemetry Collector? One could argue the same of anything that creates or receives, processes, and exports telemetry, but that's kinda my point.

    One opportunity allowed by the resemblance is replacing the custom code for representing and exporting spans with OTC's pdata and exporter packages. Crummy timing vs #175 sorry, but I didn't put all this together until just now.

    You could also use OTC's config to load the exporter configuration from YAML. Or, given it wants you to configure your environment variables in the YAML to use their envprovider, maybe not.

    I think the temptation to use OTC's receivers and the otel-desktop-viewer exporter/GUI for otel-cli server is a bit of a trap. After hooking them together with OTC's pipelines and processors you'll have a hand-crafted custom distribution of the Collector on your hands. I think it'd be more practical to remove the server, extract its TUI to an OTC exporter component like the web app, and direct users to pack their own TUI/GUI distro. A red diff is a good diff! And, then I'd advise cashing in your winnings. But, what if you felt like doubling down, instead?

    I bet if you looked at OCB's output you could figure out how to add an exec command to the OpenTelemetry Collector.

  5. garthk commented on May 7, 2023

    @garthk

    I'm sorry, all that extrapolation about what happens when you support OTC components was besides the point and didn't answer your question.

    I'm interested in configuring an exporter to spool traces to disk. It'll help deal with a few scenarios in which I can't assume connectivity, either from the CLI to the Collector or from the Collector onward.

  6. tobert commented on May 7, 2023

    @tobert
    ContributorAuthor
  7. tobert commented on Sep 28, 2023

    @tobert
    ContributorAuthor

    I'm approving my own PRs but still going through the process for transparency. If/when folks show up to do reviews for me I'll be happy to have the help, but for now, this keeps things moving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

help wantedExtra attention is needed

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    0