Repository navigation
SA1026: false positive for nil pointer to struct containing unsupported type #1712
Description
The following code:
func main() {
resp := &http.Response{
StatusCode: 200,
// ... etc
}
8000
j, err := json.Marshal(struct {
*http.Response
Body []byte
Request *http.Request
}{Response: resp, Body: []byte("ABC")})
if err != nil {
panic(err)
}
fmt.Println(string(j))
}
Works as expected; the http.Request struct contains some fields that can't be marshaled (func, channel), but it overrides the Request field:
% go run test.go
{
[..]
"StatusCode": 200,
[..]
}
But staticcheck errors:
% staticcheck test.go
test.go:15:25: trying to marshal unsupported type func() (io.ReadCloser, error), via x.Request.GetBody (SA1026)
staticcheck (devel, v0.7.0-0.dev.0.20260409232628-ba2c20843b32)
Activity
dominikh commentedon May 2, 2026
Not embedding related, this is a simpler reproducer:
The problem is that our analysis is type-based, but you can marshal a
*http.Requestas long as it is nil, because the encoder won't recurse into it to find the field of unsupported type.I don't think we can avoid this false positive in the general case (with non-trivial data flow) without neutering the check a fair bit.
[-]SA1026: false positive for fields in embedded struct that are overridden[/-][+]SA1026: false positive for nil pointer to struct containing unsupported type[/+]