Repository navigation
staticcheck: check for mistakenly returning a nil error #640
Description
I caught this code in crypto/tls
if sigType == 0 || err != nil {
c.sendAlert(alertInternalError)
return err
}
You can see that if sigType == 0 && err == nil, we return nil, when in fact an error occurred.
This feels common enough and likely enough to be a mistake that staticcheck might raise it.
Activity
ainar-g commentedon Oct 29, 2019
It looks like this will near-impossible to detect without generating lots of false-positives. A programmer could have easily decided to shorten this:
Into this:
Without it being an error.
dominikh commentedon Nov 5, 2019
I think I agree with Ainar. It is impossible for us to determine which conditionals constitute an error condition and which constitute a short-circuit that carries a possibly non-nil error forward.
This might be a good fit for a tool that reports "possibly wrong, look into this" diagnostics, but staticcheck tries to only flag things that are definitely wrong.
dominikh commentedon Oct 17, 2021
Reopening under the
aggressivelabel, for a future set of checks specific to code review.