Repository navigation
stylecheck: check for the LHS of a declaration containing a redundant type #551
Description
Follow-up from #542.
Golint has a check for the uneeded type in code like this:
var b *bytes.Buffer = bytes.NewBufferString("asdf")
should omit type *bytes.Buffer from declaration of var b; it will be inferred from the right-hand side
Staticcheck should add a "code that isn't really doing anything" check for this.
Activity
[-]staticcheck: add an SA4??? check for the LHS of a declaration containing a redundant type[/-][+]stylecheck: check for the LHS of a declaration containing a redundant type[/+]dominikh commentedon Jul 29, 2019
It's really more of a style rule, not a matter of correctness.
cespare commentedon Jul 29, 2019
Oh, I see. The SA4??? checks are about "code which isn't really doing anything, so maybe you made a mistake and intended for it to do something"?
dominikh commentedon Jul 29, 2019
That is correct.
cespare commentedon May 10, 2021
Since golint is being deprecated/removed we're getting rid of it in our org. FWIW I think this is the only useful check we're losing which isn't covered by staticcheck.
dominikh commentedon May 14, 2021
We'll add two versions of the check: one in stylecheck and one in quickfix.
The one in stylecheck will be disabled by default, but can be opted into. It will have the following exceptions to reduce false/noisy positives:
This is essentially a better version of what you had in golint.
The one in quickfix will be enabled by default, but only be used inside gopls. It will not underline code or emit warnings, but it will simply grey out redundant types and offer to remove them. It does not have the last 3 exceptions. It will result in a user experience like the following:
dominikh commentedon May 14, 2021
However, this check is probably another one for #938.
cespare commentedon May 19, 2021
Awesome, thanks!
stylecheck, quickfix: flag redundant types in variable declarations