8000 False-negative driver cert when host reports driver version but no driver name · Issue #47 · dominikzorgnotti/esx-hcl-check · GitHub
[go: up one dir, main page]

Skip to content

False-negative driver cert when host reports driver version but no driver name #47

Closed

Description

@dominikzorgnotti

Problem

Running against a live ESXi 9.1 host, a RAID controller shows driver_certified: "N/A" even though its current_driver_version clearly matches an entry in supported_drivers (seen via -json):

{
  "device": "HPE P408i-a SR Gen10",
  "device_type": "io card (raid)",
  "current_driver_version": "90.4900.0.5000",
  "driver_name": "",
  "driver_certified": "N/A",
  "supported_drivers": ["smartpqi 90.4900.0.5000-3vmw.910"]
}

The host's 90.4900.0.5000 matches the HCL base version 90.4900.0.5000 (from 90.4900.0.5000-3vmw.910), so this is a false-negative.

Root cause

  1. For RAID/SAS/block HBAs on ESXi 9.1+, driver version + firmware are pulled via the raw SOAP call in parseHBAFirmwareFromSOAP (vsphere.go), which extracted firmwareVersion and driverVersion but not the <driver> (module name) element. So driver_name came back empty.
  2. The matcher in hcl.go (evaluateVsanPCI) gated driver certification on the driver name — both the CertFalse baseline (DriverName != "" && DriverVer != "") and the version comparison (strings.Contains(res.DriverName, drvName)). With an empty name, the version comparison never ran, leaving the result at N/A.

Fix

  • Extract the <driver> module name in parseHBAFirmwareFromSOAP and carry it into the RAID/block HBA entries so driver_name is populated.
  • Add a version-only fallback in the matcher: when the host reports a driver version but no name, judge certification by matching the version against the device's already-PCI-matched supported drivers. Name matching stays enforced when a name is present (no blanket pass).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0