This repository was archived by the owner on Oct 31, 2018. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 31, 2018. It is now read-only.
Pausing internally gets overridden by downstream streams #11
Description
e.g.
source.pipe(through(function (chunk) {
var self = this;
console.log('start');
self.pause();
setTimeout(function () {
console.log('end');
self.resume();
}, 1000);
})
.pipe(process.stdout);if you stream chunks from source, will print:
start
start
start
start
end
end
end
end
because the resumes from the process.stdout stream break the pauses within the through stream.
Activity
ForbesLindesay commentedon Apr 6, 2013
Can be worked around with code like:
dominictarr commentedon Apr 6, 2013
cool, that may be desired is some use-cases, depending on how the dest emits 'resume'.
You should publish this as an npm module!
ForbesLindesay commentedon Apr 6, 2013
Will do, was just thinking perhaps this should be part of how the core of through works?
dominictarr commentedon Apr 7, 2013
what version of node are you using?
ForbesLindesay commentedon Apr 7, 2013
0.8, I'm looking to update to 0.10 soon, but I need to find time to re-test my apps.
dominictarr commentedon Apr 7, 2013
Ah, so it must be that stdout is emitting resume too often.
If stdout says it can handle data, then that is it's business though.
Pause is just for stopping the flow if the dest has more than it can handle.
If you are trying to do something else, like just block output...
That should be a different module.
It might be better to add another method
hardPausewhich totally prevents output...