[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some flaky int tests #7982

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

cicoyle
Copy link
Contributor
@cicoyle cicoyle commented Aug 12, 2024

Trying to fix some flakiness with:

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
@cicoyle cicoyle requested review from a team as code owners August 12, 2024 22:28
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
mikeee
mikeee previously approved these changes Aug 13, 2024
Copy link
Member
@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cicoyle cicoyle changed the base branch from release-1.14 to master August 14, 2024 19:01
@cicoyle cicoyle dismissed mikeee’s stale review August 14, 2024 19:01

The base branch was changed.

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
@cicoyle
Copy link
Contributor Author
cicoyle commented Aug 14, 2024

I can't repro this unit test failure. This PR addresses all others I've seen thus far

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
@cicoyle cicoyle requested a review from JoshVanL August 15, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants