8000 Comparing v3.2.21...v3.2.22 · damoahdominic/occ · GitHub
[go: up one dir, main page]
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: damoahdominic/occ
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.2.21
Choose a base ref
...
head repository: damoahdominic/occ
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.2.22
Choose a head ref
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on Mar 18, 2026

  1. fix: Windows app icons not showing correctly 

    - VisualElementsManifest.xml: change ShortDisplayName from "Void" to "OCcode"
- VisualElementsManifest.xml: change BackgroundColor from white to dark (#1a1a1a)
- code.iss: add explicit IconFilename to Start Menu, Desktop, and Quick Launch shortcuts
- CI: add rcedit step to stamp code.ico on main OCcode.exe after packaging

The Start Menu and taskbar were showing default/generic icons because:
1. VisualElements manifest still referenced "Void" as the display name
2. InnoSetup shortcuts did not explicitly set IconFilename
3. Main exe may not have had the icon stamped by Electron packaging
    @damoahdominic
    damoahdominic committed Mar 18, 2026
    Configuration menu
    Copy the full SHA
    e6e185e View commit details
    Browse the repository at this point in the history

  2. chore: remove stale ico_256.png debug file

    @damoahdominic
    damoahdominic committed Mar 18, 2026
    Configuration menu
    Copy the full SHA
    f68da06 View commit details
    Browse the repository at this point in the history

  3. fix(macos): Xcode CLI screen, binary path storage, chown group error 

    - Xcode not installed: show dedicated panel-xcode-required with
  step-by-step instructions and a Retry button instead of failing
  silently into the log
- Post-install PATH issue: capture the binary's absolute path
  immediately after npm install succeeds (via npm config get prefix
  + known candidate paths); verifyCliBeforeSetup uses this stored
  path directly, skipping PATH lookup entirely
- chown group error: was using chown -R user:user which fails when
  the macOS username isn't registered as a group; changed to
  chown -R user (no group suffix)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
    @damoahdominic @claude
    damoahdominic and claude committed Mar 18, 2026
    Configuration menu
    Copy the full SHA
    6cc6d9e View commit details
    Browse the repository at this point in the history
Loading
0