You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
utils: Document difference between compute_p_from_null_distribution and p_from_null #397
As far as I can tell p_from_null was performing a specific function that was only used in the old isfc function, and is no longer referenced anywhere in brainiak. In this case, I think compute_p_from_null_distribution supersedes p_from_null, and p_from_null can be removed. However, I may shorten the name of compute_p_from_null_distribution as I only named it this to not overlap with the pre-existing p_from_null.
Replaced old p_from_null with newer functionality from compute_p_from_null_distribution in #405 (commit daa5d41). Note that the new functionality now uses the older simpler function name. This also required removing the ecdf functionality which is no longer used anywhere in BrainIAK (commit aa0c37d.
Activity
snastase commentedon Jan 21, 2019
As far as I can tell
p_from_nullwas performing a specific function that was only used in the oldisfcfunction, and is no longer referenced anywhere inbrainiak. In this case, I thinkcompute_p_from_null_distributionsupersedesp_from_null, andp_from_nullcan be removed. However, I may shorten the name ofcompute_p_from_null_distributionas I only named it this to not overlap with the pre-existingp_from_null.mihaic commentedon Jan 22, 2019
That makes sense. Please remember to include a news item about the removal of
p_from_null(see point 7 http://brainiak.org/docs/contributing.html#how-to-contribute). Looking forward to the PR!snastase commentedon Mar 3, 2019
Replaced old
p_from_nullwith newer functionality fromcompute_p_from_null_distributionin #405 (commit daa5d41). Note that the new functionality now uses the older simpler function name. This also required removing theecdffunctionality which is no longer used anywhere in BrainIAK (commit aa0c37d.