You signed in with another tab or window. Reload to refresh your s
8000
ession.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
8000
isc: phaseshift_isc overlaps with brainiak.utils.phase_randomize #396
These are not really functional duplicates. I think in theory what we want is (a) phaseshift_isc, which performs the nonparametric test using phase randomization and returns a null distribution, p-values, etc; and (b) a more generic phase_randomize utility that simply takes in time-series and phase-randomizes them. I think having this phase_randomize utility is useful even outside the context of ISC analysis. And ideally, the phaseshift_isc function should use the phase_randomize function internally. This was a little tricky because the pairwise and leave-one-out ISC approaches apply the phase randomization slightly differently, but should be work now—see #405 (commit dba670a). I've updated phaseshift_isc in isc, utils and tests to match.
Activity
snastase commentedon Mar 3, 2019
These are not really functional duplicates. I think in theory what we want is (a)
phaseshift_isc, which performs the nonparametric test using phase randomization and returns a null distribution, p-values, etc; and (b) a more genericphase_randomizeutility that simply takes in time-series and phase-randomizes them. I think having thisphase_randomizeutility is useful even outside the context of ISC analysis. And ideally, thephaseshift_iscfunction should use thephase_randomizefunction internally. This was a little tricky because the pairwise and leave-one-out ISC approaches apply the phase randomization slightly differently, but should be work now—see #405 (commit dba670a). I've updatedphaseshift_iscinisc,utilsand tests to match.mihaic commentedon Mar 27, 2019
There's a way to close issues with commit messages such that it is clear they were fixed. I think we should use it in the future:
https://help.github.com/articles/closing-issues-using-keywords/