You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Will do!
Also noted in the PR that maybe a separate NS should be created instead of inlining the missing functions directly?
Babashka does this with a core-extras in an "impl"-namespace
I tried to applying the recent update to sci.configs to Jet and noticed that leiningen is still used to build and test, which doesn't support referencing git-dependencies!
I can try to assist with moving to building using deps.edn instead if that's a good direction for the project, but for now it looks like this issue will be resolved with the next release 😊
Activity
borkdude commentedon Jul 10, 2023
Can you make a repro?
Oddsor commentedon Jul 10, 2023
I made a PR with tests instead!
#138
Edit: And here's an example to illustrate the problem where I convert the keys in a map into keywords:
borkdude commentedon Jul 10, 2023
Thanks :)
I noticed the changelogs weren't updated yet. Can you do this too?
Oddsor commentedon Jul 10, 2023
Will do!
Also noted in the PR that maybe a separate NS should be created instead of inlining the missing functions directly?
Babashka does this with a
core-extrasin an "impl"-namespaceborkdude commentedon Jul 10, 2023
Yes, I think moving this extra config to sci.configs will be even better so then we can re-use it in both bb and jet and possibly more projects.
Oddsor commentedon Jul 10, 2023
Okay, so maybe the current PR should be closed and then I can open one for SCI where the functions are added to
clojure-corehere?https://github.com/babashka/sci/blob/master/src/sci/impl/namespaces.cljc#L991C11-L991C11
borkdude commentedon Jul 10, 2023
No, not in SCI, but in https://github.com/babashka/sci.configs.
Oddsor commentedon Jul 10, 2023
Cool, I'll give updating sci.configs a try later today 😊
Oddsor commentedon Jul 12, 2023
I tried to applying the recent update to sci.configs to Jet and noticed that leiningen is still used to build and test, which doesn't support referencing git-dependencies!
I can try to assist with moving to building using deps.edn instead if that's a good direction for the project, but for now it looks like this issue will be resolved with the next release 😊
borkdude commentedon Jul 12, 2023
Ah yes, sorry, I didn't notice that. We can move to tools.build. I'll make an issue for that and solve that myself, if nobody else jumps on it.