[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bolt-rawgen: Please write to a new file #2

Open
tv42 opened this issue Jan 17, 2015 · 2 comments
Open

bolt-rawgen: Please write to a new file #2

tv42 opened this issue Jan 17, 2015 · 2 comments

Comments

@tv42
Copy link
tv42 commented Jan 17, 2015

Editing the main source file is just evil. It makes diffs harder to read, it messes with the files open in my editor, and what go generate stuff is out there has already settled into writing new files.

My personal favorite has been to use *.gen.go for generated go source. Stringer (https://godoc.org/golang.org/x/tools/cmd/stringer) seems to use *_string.go, but that's a bit weird to me because it interacts with build tags..
@chrsm
Copy link
chrsm commented Aug 9, 2015

👍 On this. I think generated files should be separate from the main source.

Would you be open to accepting a PR for this @benbjohnson, or is there a reason this is not currently done?

@benbjohnson
Copy link
Member

Sure, I'd accept a PR. Thanks, @chrsm. 👍

@chrsm chrsm mentioned this issue Aug 12, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bolt-rawgen: Write generated code to a new file.
3 participants
@benbjohnson @tv42 @chrsm