[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoxflate lzo & visuals are broken #1944

Open
1 of 2 tasks
pstorz opened this issue Aug 29, 2024 · 1 comment
Open
1 of 2 tasks

autoxflate lzo & visuals are broken #1944

pstorz opened this issue Aug 29, 2024 · 1 comment
Assignees
Labels
bug This addresses a bug

Comments

@pstorz
Copy link
Member
pstorz commented Aug 29, 2024

Currently the autodeflate setup code looks like this:

switch (autodeflate) {
...
#if defined(HAVE_LZO)
    case COMPRESS_LZO1X:
      compressorname = COMPRESSOR_NAME_LZO;
      break; // nothing is set up; is this intentional ?
#endif
 
    case COMPRESS_FZFZ:
      compressorname = COMPRESSOR_NAME_FZLZ;
      [[fallthrough]];
    case COMPRESS_FZ4L:
      compressorname = COMPRESSOR_NAME_FZ4L;
      [[fallthrough]];
    case COMPRESS_FZ4H: {
      compressorname = COMPRESSOR_NAME_FZ4H; // compressor name is always overriden to FZ4H
      ...
     }
  ...
}
Jmsg(ctx, M_INFO, T_("autoxflate-sd: Compressor on device %s is %s\n"),
     dcr->dev_name, compressorname);

We need to

  • Check if lzo compression works
  • Fix the compressor name output if any FZ* algorithm is chosen.
    This can easily be done by checking compressorname == COMPRESSOR_NAME_UNSET before each assignment.
@arogge arogge added the bug This addresses a bug label Sep 19, 2024
@sebsura
Copy link
Contributor
sebsura commented Oct 9, 2024

lzo works. It just does not need further setup (as it does not have any levels)

@sebsura sebsura assigned pstorz and sebsura and unassigned pstorz Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This addresses a bug
Projects
None yet
Development

No branches or pull requests

3 participants