[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out application which are not in use #14

Open
jonaslagoni opened this issue Nov 28, 2022 · 4 comments
Open

Filter out application which are not in use #14

jonaslagoni opened this issue Nov 28, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers stale

Comments

@jonaslagoni
Copy link
Member
jonaslagoni commented Nov 28, 2022 •
edited
Loading

Describe the bug

In the ApplicationFocusView, it always shows external applications, regardless of whether the application interacts with it or not, but I don't think that gives any value to the user because why would you care about other applications you don't interact with? If you want a larger picture you would use SystemView.

image

So I would suggest we filter out all external applications which do not interact with the primary application.

The external application nodes are created here:

EDAVisualiser/library/src/visualiser/helpers/collect-nodes.ts

Line 96 in 19b7da7

if (external) {

This is also the location for filtering out applications if they have no correlating operations to the focused application.

I would suggest doing something along the lines of:

  • Track all the channels that the primary application uses (in an array or map or similar)
  • Dependant on how the external application is created (from AsyncAPI or core building blocks), we cross-reference against the above list to filter out any nodes that are irrelevant.

In case you have any questions or problems feel free to ping me here or on slack 🙂
@jonaslagoni jonaslagoni added enhancement New feature or request good first issue Good for newcomers labels Nov 28, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 29, 2023
@ankur0904
Copy link
Contributor

@jonaslagoni I want to work on this issue.

@jonaslagoni
Copy link
Member Author

Go for it @ankur0904 👍

@ankur0904
Copy link
Contributor

Thanks @jonaslagoni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonaslagoni @ankur0904