Repository navigation
diffApply array bug #590
Description
There is a bug in diffApply function from just-diff-apply package
import { diff } from 'just-diff'
import { diffApply } from 'just-diff-apply'
const source = { a: [ 1, 2, 3, 4, 5 ] }
const newSource = { a: [ 1, 2, 5 ] }
const changes = diff(source, newSource) // [{ op: 'remove', path: ['a', 4] }, { op: 'remove', path: ['a', 3] }, { op: 'replace', path: ['a', 2], value: 5 }]
console.log(changes)
// Expected value is newSource, but got only the array [1, 2, 5]
const appliedChanges = diffApply(source, changes) // [1, 2, 5]
console.log(appliedChanges)If I replace return subObject in diffApply function with return obj I will get correct result
Activity
alvindev111 commentedon Oct 16, 2026
Confirmed on current
masteratd8c5dd18941062d8db7e9310ecc8f53fd607df54(checked 2026-10-17): the current implementation still returnssubObject.Expected:
returnedis the patched root{a: [1, 2, 5]}andreturnedIsSourceistrue.Actual:
sourceis patched, butreturnedis[1, 2, 5]andreturnedIsSourceisfalse. The path walk changessubObjectto the nested array, so the finalreturn subObjectreturns that container; returningobjwould preserve the root result.