8000 updater broken in windows? · Issue #125 · amirlehmam/wmux · GitHub
[go: up one dir, main page]

Skip to content

updater broken in windows? #125

Closed
Closed

Description

@arnonuem

It seems that windows does not have access to the sophisticated inline updater which pulls the binary itself and applies it.

When i click the button i am just redirected to the github repo where i have to download the installer myself and have to manually install it.

Is this intendet behaviour?

Image

Activity

  1. amirlehmam commented on Jul 28, 2026

    @amirlehmam
    Owner

    No, that was not intended — and it's fixed in v0.38.0.

    Windows was never missing the updater. electron-updater has been running the whole time; it just had no UI. The badge you clicked came from a separate, notify-only GitHub poll whose only action was ever openExternal(release page), so from the outside it looked exactly like "this platform doesn't get real updates". Two update paths, and the one you could see was the one that couldn't install anything.

    The badge now drives the real updater:

    • Click → checks, then downloads in place. The badge shows the percentage while it runs.
    • When it's ready → the badge turns amber and reads Restart; clicking it (or accepting the dialog) restarts into the new version.
    • If this build genuinely can't self-update — a dev run, WMUX_DISABLE_UPDATER=1, or a release published without latest.yml — it falls back to opening the release page, same as before. That path is now the exception rather than the only behaviour.

    One deliberate detail: clicking the badge skips the 3-day quarantine window. That window exists to stop a malicious release from installing itself unattended before it can be spotted and yanked (#29) — it is not meant to stop you from installing a version you just read the number of and clicked. The unattended path still waits it out unchanged, and the install still needs your confirmation. Without this, a freshly published release would have shown a badge that did nothing for three days, which is the bug you filed wearing a different hat.

    Note that the update from 0.37.0 still has to be done by hand — the fix ships in the version you're updating to. From 0.38.0 onward the badge does it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0