[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PersistentVolumeClaim retention feature #892

Closed
3 of 4 tasks
Setsushin opened this issue Sep 25, 2024 · 2 comments
Closed
3 of 4 tasks

Support PersistentVolumeClaim retention feature #892

Setsushin opened this issue Sep 25, 2024 · 2 comments
Labels
kind/enhancement kind - new features or changes

Comments

@Setsushin
Copy link

Checks

Motivation

Sometimes we need extra workers for large tasks, but these tasks don't occur very often.
We prefer not to keep workers on standby all the time, as this helps reduce costs.

Implementation

Ref: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#persistentvolumeclaim-retention

Add .spec.persistentVolumeClaimRetentionPolicy property to the template file.

Are you willing & able to help?

  • I am able to submit a PR!
  • I can help test the feature!
@Setsushin Setsushin added the kind/enhancement kind - new features or changes label Sep 25, 2024
@thesuperzapper
Copy link
Member

@Setsushin we don't currently mount any PVCs on the worker StatefulSet by default.

Are you mounting one for some reason, and if so, can you confirm what you use this PVC for?

@Setsushin
Copy link
Author
Setsushin commented Oct 16, 2024

@thesuperzapper

Sorry, this is my misunderstanding. I found that the chart I used is not the community version but the official version. The official version defaults to using PVC and supports the configuration ofpersistentVolumeClaimRetentionPolicy.

Thanks for the reply and have a good day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement kind - new features or changes
Projects
None yet
Development

No branches or pull requests

2 participants