8000 ecrecover implementation issue · Issue #81 · aionnetwork/aion_web3 · GitHub
[go: up one dir, main page]

Skip to content

ecrecover implementation issue #81

Open

Description

@vaishnavipanchal23

Web3 version: aion-web3 v1.2.6-beta.0

Implementation issue of recover function https://github.com/aionnetwork/aion_web3/blob/v1.1/packages/web3-eth-accounts/src/index.js#L316

Current implementation:
Returns the address by retrieving the public key from first 32 bytes of the signature. This ignores the signature verification completely.

Expected implementation:
Return the address of the signer only if the signature is verified for the given message.

Note: Also, this function name should be edverify.

Activity

  1. rakeshgohel01 commented on Nov 1, 2019

    @rakeshgohel01

    Two things

    1. Confirm the claim that there is a missing implementation for ecrecover.

    2. For web3 implementation, ecrecover has been used in the context of secp256k1 curve and must be separated from edverify for ed25519 signature verification which is primarily used by Aion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0