Repository navigation
cli: jiji service prune counts tags instead of images #111
Description
Summary
jiji service prune has the same tag-versus-image counting gap as the agent's continuous retention (#109). It applies --retain N to tag rows, so a multi-tagged image is miscounted and its removal by ID fails.
Where
crates/jiji-cli/src/commands/service/prune.rs, prune_service_images:
- Lists
images --format '{{.ID}}' --filter reference=<repo>, which repeats the same ID once per tag (confirmed on Docker; see agent: image retention counts tags instead of images, and rmi by ID fails on multi-tagged images #109 for the reproduction). .skip(retain_n)over those rows counts tags, not images.- Removal goes through
container_ops::remove_image_if_presentby ID, which fails for an image with more than one tag.
Proposed fix
Same approach as #109, ideally sharing the grouping logic: list {{.ID}} {{.Repository}}:{{.Tag}}, group by ID in listing order, apply retain to distinct images, keep any image with an in-use tag, and remove stale tags by repo:tag. The command's per-image output (Removed / Retained / Failed) should report per image, not per row.
Activity