8000 Blockquote text is unreadable on dark themes: quote colour aliases the hard-coded #4f525a marker grey and ignores the theme · Issue #163 · omacom/omawrite · GitHub
[go: up one dir, main page]

Skip to content

Blockquote text is unreadable on dark themes: quote colour aliases the hard-coded #4f525a marker grey and ignores the theme #163

Open

Description

@DerailleurAgile

On dark themes, blockquote text is nearly unreadable: it's drawn in a hard-coded #4f525a, which ignores the Omarchy theme entirely. On Kanagawa's #1f1f28 background that's a 2.1:1 contrast ratio, well below WCAG AA (4.5:1) for body text.

Cause

MarkdownHighlighter::rebuildFormats() (src/markdownhighlighter.cpp:115-123) hard-codes the marker colour and then reuses it for quote content:

const QColor marker = m_darkMode ? QColor(QStringLiteral("#4f525a"))
                                 : QColor(QStringLiteral("#aeb1b5"));
...
const QColor quote = marker;

background, text and link all prefer the theme's colours (m_customBackground / m_customForeground / m_customAccent), but marker (and so quote) never does. Dimming the >, #, 1. and fence markers that much makes sense, since they're meant to recede. A blockquote's body is prose the writer has to read, though, and it gets the same faint grey.

(Main.qml:21 even uses a brighter dark-mode mutedColor of #909191 for the UI chrome than the editor uses for quoted text.)

Repro

  1. omarchy theme set kanagawa (any dark theme shows it; a darker grey background makes it worst)
  2. omawrite, then type:
    1. Question
        > A paragraph-length answer written as a blockquote...
  3. The answer text renders in #4f525a italic on #1f1f28, which is very hard to read

Suggested fix

  • Keep marker dim, but don't alias quote to it. Use the theme foreground for quote text, perhaps at reduced opacity or blended toward the background (italics already set it apart). Something like #a6a69c on Kanagawa gives about 6.7:1.
  • Optionally derive marker from the theme too. Omarchy's colors.toml ships muted and dark_foreground (e.g. Kanagawa: muted = "#54546D", dark_foreground = "#727169"), so markers would match the rest of the desktop instead of being a fixed grey on every theme.

Omawrite 0.7.2 (Arch package), checked against main @ 9d713b9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0