8000 Identify CMake antipattern of putting CMakeLists.txt in src subfolder · Issue #53 · nix-community/nix-init · GitHub
[go: up one dir, main page]

Skip to content

Identify CMake antipattern of putting CMakeLists.txt in src subfolder #53

Open

Description

@MatthewCroughan

Below are two examples of projects that are easy to package with nix-init, except the CMakeLists.txt are wrongly stored in the src/ subfolder of the project, which also confuses Nix's CMake hooks. All I had to do to compile these projects after running nix-init was

  1. add cmake to nativeBuildInputs
  2. add `preConfigure = "cd src";

It's possible that this case could be caught by nix-init

Activity

  1. SomeoneSerge commented on Apr 15, 2023

    @SomeoneSerge

    Maybe this could be generalized to cargo.toml and probably others: https://github.com/huggingface/safetensors

  2. figsoda commented on Apr 15, 2023

    @figsoda
    Member

    Also see #72 (comment), I think it's a good idea to have an option to look for these files in sub-directories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0