You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, there appears to be some useful code in there. In particular it may be useful to compare other algorithms to SPM, and JB tells me the ReML algorithm is pleasantly easy to follow.
We should review this code, at very least add tests, consider removing code that won't be used, and perhaps refactor the rest into other places in the codebase.
if code is lying around and not being used anywhere else in the library and is not part of the api, remove it (this is git - you can always get back to it if needed). also given that the most useful aspect here is reml, that should be moved to a more aptly named place - reml is an algorithm and has nothing to do with spm per se except they use it. it should really be part of scipy or statsmodels.
Activity
satra commentedon May 18, 2012
if code is lying around and not being used anywhere else in the library and is not part of the api, remove it (this is git - you can always get back to it if needed). also given that the most useful aspect here is reml, that should be moved to a more aptly named place - reml is an algorithm and has nothing to do with spm per se except they use it. it should really be part of scipy or statsmodels.
GaelVaroquaux commentedon May 30, 2012
+1 for moving ReML, and removing the rest.