8000 Consider what to do about fmri/spm code · Issue #166 · nipy/nipy · GitHub
[go: up one dir, main page]

Skip to content

Consider what to do about fmri/spm code #166

Open

Description

@matthew-brett

Bertrand noticed that the code in nipy/modalities/fmri/spm had no tests and suggested it could be deleted:

#157

However, there appears to be some useful code in there. In particular it may be useful to compare other algorithms to SPM, and JB tells me the ReML algorithm is pleasantly easy to follow.

We should review this code, at very least add tests, consider removing code that won't be used, and perhaps refactor the rest into other places in the codebase.

Activity

  1. satra commented on May 18, 2012

    @satra
    Member

    if code is lying around and not being used anywhere else in the library and is not part of the api, remove it (this is git - you can always get back to it if needed). also given that the most useful aspect here is reml, that should be moved to a more aptly named place - reml is an algorithm and has nothing to do with spm per se except they use it. it should really be part of scipy or statsmodels.

  2. GaelVaroquaux commented on May 30, 2012

    @GaelVaroquaux
    Member

    +1 for moving ReML, and removing the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0