Repository navigation
Melpa package of magithub broken #11
Description
Hello,
I have magit and magithub installed with M-x package-list-packages. When I try to load magit (yes, magit, not magithub), I get this error:
(void-variable magit-log-edit-confirm-cancellation)
This is what's happening:
- loading magit triggers loading magithub because of
;;;###autoload
(eval-after-load 'magit
'(unless (featurep 'magithub)
(require 'magithub)))
- in magithub, there is this form:
(defcustom magithub-message-confirm-cancellation magit-log-edit-confirm-cancellation
"If non-nil, confirm when cancelling the editing of a `magithub-message-mode' buffer."
:group 'magithub
:type 'boolean)
- evaluating it raises the error because magit-log-edit-confirm-cancellation is not defined.
Maybe the variable has been removed? Dunno.
Michael.
Activity
pashinin commentedon Aug 18, 2013
Confirm
pokehanai commentedon Aug 19, 2013
+1
Remove dependence on void magit variable
aspiers commentedon Aug 20, 2013
+1
ocodo commentedon Sep 3, 2013
Question, why is this closed when the MELPA install is still broken?
flexibeast commentedon Sep 3, 2013
@jasonm23:
As far as I can tell, looking at the issue status indicator at the top of this page, this issue isn't closed. If I'm understanding things correctly, the 'Closed' indicator earlier in this thread is a reference to the issue being closed on the /magit/ repo, as the issue is not with magit itself, but with /magithub/, a distinct project.
ocodo commentedon Sep 3, 2013
@flexibeast thanks for clearing that up. It seems that the melpa package is still a release from July. (?)
flexibeast commentedon Sep 3, 2013
@jasonm23:
Yes, that's the latest release I'm seeing also .... Basically I've 86A5 uninstalled magithub until this issue is fixed, so that I can at least continue using magit.
Blaisorblade commentedon Sep 6, 2013
I had the same problem.
It seems that saving
magithub-message-confirm-cancellationfromM-x customize-group RET magithub RETalso works the problem around (I guess because once the variable is set, reading the default isn't needed any more).dcunited001 commentedon Sep 10, 2013
+1
alexvorobiev commentedon Sep 29, 2013
Adding
(defvar magit-log-edit-confirm-cancellation nil)prior to loading magit is another workaround.Blaisorblade commentedon May 4, 2014
Apparently magithub is unsupported and does not work anyway, see melpa/melpa#1126.