[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mitmdump no longer shows failed CONNECT for nonexisting domain #7083

Open
Prinzhorn opened this issue Aug 6, 2024 · 2 comments
Open

mitmdump no longer shows failed CONNECT for nonexisting domain #7083

Prinzhorn opened this issue Aug 6, 2024 · 2 comments
Labels
area/protocols kind/bug

Comments

@Prinzhorn
Copy link
Member
Prinzhorn commented Aug 6, 2024 •
edited
Loading

Problem Description

Via #7081

Steps to reproduce the behavior:

  1. mitmdump
  2. curl --insecure --proxy localhost:8080 https://doesnot1321exist.ac

Compare 10.0.0 with 10.4.1 (edit: 10.4.2 same)

image

It works up until 10.3.1
@Prinzhorn Prinzhorn added the kind/triage Unclassified issues label Aug 6, 2024
@mhils
Copy link
Member
mhils commented Aug 6, 2024

Bisected to be56a0a, /cc @errorxyz

@mhils mhils added kind/bug area/protocols and removed kind/triage Unclassified issues labels Aug 6, 2024
@mhils
Copy link
Member
mhils commented Aug 6, 2024

I think the correct fix here is to handle HttpConnectErrorHook in the termlog addon.

Note that mitmproxy and mitmweb don't show anything in the flow list either (only in the event log). I believe this is something we should eventually look at fixing separately, let's keep this here focused on the regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/protocols kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Prinzhorn @mhils