Make Resolver type definition more accurate #80
Labels
enhancement
New feature or request
Comments
|
This is achievable via @rafalp Let me know if the definitions below would be correct. class Resolver(Protocol):
def __call__(self, obj: Any, info: GraphQLResolveInfo, **kwargs: Any) -> Any:
pass
class TypeResolver(Protocol):
def __call__(self, obj: Any, *_: Any) -> Optional[str]:
passIf so, I'd love to make a contribution. EDIT # Note: Contrary to the Javascript implementation of GraphQLFieldResolver,
# the context is passed as part of the GraphQLResolveInfo and any arguments
# are passed individually as keyword arguments.
GraphQLFieldResolverWithoutArgs = Callable[[Any, GraphQLResolveInfo], Any]
# Unfortunately there is currently no syntax to indicate optional or keyword
# arguments in Python, so we also allow any other Callable as a workaround:
GraphQLFieldResolver = Callable[..., Any]
# Note: Contrary to the Javascript implementation of GraphQLTypeResolver,
# the context is passed as part of the GraphQLResolveInfo:
GraphQLTypeResolver = Callable[
[Any, GraphQLResolveInfo, "GraphQLAbstractType"],
AwaitableOrValue[Optional[Union["GraphQLObjectType", str]]],
]However, Should ariadne import types from graphql-core or use its own definitions? Anyway, the class Resolver(Protocol):
def __call__(self, obj: Any, info: GraphQLResolveInfo, **kwargs: Any) -> Any:
pass |
|
We could use type definitions from graphql-core and and run extra checks on our side at type's definition time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our current type for
ResolverisCallable[..., Any], catching any arguments and relasing anything.This is because its currently impossible to tpe
Callablethat accepts*argsor**kwagrs.This issue is [known to MyPy authors](python/typing#264 but a the time of writing no solution is available.
This is related to #79
The text was updated successfully, but these errors were encountered: