[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: vcpkg does not add default features when a dependency is already installed #36781

Open
dg0yt opened this issue Feb 16, 2024 · 2 comments
Open

Regression: vcpkg does not add default features when a dependency is already installed #36781

dg0yt opened this issue Feb 16, 2024 · 2 comments
Assignees
@BillyONeal @FrankXie05
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)

Comments

@dg0yt
Copy link
Contributor
dg0yt commented Feb 16, 2024 •
edited
Loading

Port pango depends (by manifest) on the default features of harfbuzz, including harfbuzz[freetype].

$ vcpkg remove --recurse harfbuzz pango
The following packages are not installed:
    harfbuzz:x64-linux
    pango:x64-linux
$ vcpkg install --dry-run pango
Computing installation plan...
The following packages will be built and installed:
  * harfbuzz[core,freetype]:x64-linux -> 8.3.0#3
    pango:x64-linux -> 1.50.14#4
Additional packages (*) will be modified to complete this operation.
$ vcpkg install --dry-run pango harfbuzz[core]
Computing installation plan...
The following packages will be built and installed:
    harfbuzz[core,freetype]:x64-linux -> 8.3.0#3
    pango:x64-linux -> 1.50.14#4

Actual behavior

When harfbuzz[core] is already installed, harfbuzz[freetype] is not added to the installed set:

$ vcpkg remove --recurse harfbuzz pango
The following packages are not installed:
    harfbuzz:x64-linux
    pango:x64-linux
$ vcpkg install harfbuzz[core] >/dev/null 2>&1
$ vcpkg install --dry-run pango
Computing installation plan...
The following packages will be built and installed:
    pango:x64-linux -> 1.50.14#4
$ vcpkg install --dry-run pango harfbuzz[core]
Computing installation plan...
The following packages are already installed:
    harfbuzz:x64-linux -> 8.3.0#3
The following packages will be built and installed:
    pango:x64-linux -> 1.50.14#4

If not a dry run, this leads to a build error because pango needs hb_ft.h.

Similar, no change when only requesting harfbuzz without specifying [core]:

$ vcpkg remove --recurse harfbuzz pango
The following packages are not installed:
    harfbuzz:x64-linux
    pango:x64-linux
$ vcpkg install harfbuzz[core] >/dev/null 2>&1
$ vcpkg install --dry-run harfbuzz
Computing installation plan...
The following packages are already installed:
    harfbuzz:x64-linux -> 8.3.0#3

Expected behavior

After installing harfbuzz[core]:

  • Installing pango should require a reinstallation of harfbuzz with freetype included.
  • Installing harfbuzz should require a reinstallation of harfbuzz with freetype included.
@dg0yt dg0yt added the category:port-bug The issue is with a library, which is something the port should already support label Feb 16, 2024
@FrankXie05 FrankXie05 added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) and removed category:port-bug The issue is with a library, which is something the port should already support labels Mar 4, 2024
@FrankXie05
Copy link
Contributor

@BillyONeal @vicroms

@BillyONeal BillyONeal self-assigned this Mar 9, 2024
@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 5, 2024

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label Sep 5, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
@BillyONeal BillyONeal reopened this Sep 23, 2024
@github-actions github-actions bot removed the Stale label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillyONeal BillyONeal

@FrankXie05 FrankXie05

Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BillyONeal @dg0yt @FrankXie05