-
Notifications
You must be signed in to change notification settings - Fork 12
/
delete_test.go
270 lines (224 loc) · 7.74 KB
/
delete_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
package cmd
import (
"errors"
"io/fs"
"sort"
"testing"
"github.com/google/go-cmp/cmp"
"github.com/simontheleg/konf-go/config"
"github.com/simontheleg/konf-go/konf"
"github.com/simontheleg/konf-go/prompt"
"github.com/simontheleg/konf-go/store"
"github.com/simontheleg/konf-go/testhelper"
"github.com/spf13/afero"
"github.com/spf13/cobra"
"k8s.io/utils/strings/slices"
)
func TestDeleteKonfWithID(t *testing.T) {
fm := testhelper.FilesystemManager{}
storeDir := config.StoreDir()
tt := map[string]struct {
fsCreator func() afero.Fs
idToDelete konf.KonfID
expError error
expFiles []string
notExpFiles []string
}{
"file was found": {
fsCreator: testhelper.FSWithFiles(fm.SingleClusterSingleContextEU, fm.SingleClusterSingleContextASIA),
idToDelete: "dev-eu_dev-eu-1",
expError: nil,
expFiles: []string{storeDir + "/dev-asia_dev-asia-1.yaml"},
notExpFiles: []string{storeDir + "/dev-eu_dev-eu-1.yaml"},
},
"file was not found": {
fsCreator: testhelper.FSWithFiles(fm.SingleClusterSingleContextASIA),
idToDelete: "dev-eu_dev-eu-1",
expError: fs.ErrNotExist,
expFiles: []string{storeDir + "/dev-asia_dev-asia-1.yaml"},
notExpFiles: []string{},
},
}
for name, tc := range tt {
t.Run(name, func(t *testing.T) {
fsm := tc.fsCreator()
err := deleteKonfWithID(fsm, tc.idToDelete)
if !errors.Is(err, tc.expError) {
t.Errorf("Exp err to be %q, got %q", tc.expError, err)
}
for _, f := range tc.expFiles {
if _, err := fsm.Stat(f); err != nil {
t.Errorf("Exp file %q to exist, but it does not", f)
}
}
for _, s := range tc.notExpFiles {
_, err := fsm.Stat(s)
if err == nil {
t.Errorf("Exp file '%s' to be deleted, but it still exists", s)
}
if err != nil && !errors.Is(err, fs.ErrNotExist) {
t.Fatalf("An unexpected error has occurred: %q", err)
}
}
})
}
}
func TestIDsForGlobs(t *testing.T) {
fm := testhelper.FilesystemManager{}
tt := map[string]struct {
fsCreator func() afero.Fs
patterns []string
expIDs []string
expError error
}{
"single argument no glob": {
fsCreator: testhelper.FSWithFiles(fm.SingleClusterSingleContextEU, fm.SingleClusterSingleContextASIA, fm.SingleClusterSingleContextEU2, fm.SingleClusterSingleContextASIA2),
patterns: []string{"dev-eu_dev-eu-1"},
expIDs: []string{"dev-eu_dev-eu-1"},
expError: nil,
},
"single argument glob": {
fsCreator: testhelper.FSWithFiles(fm.SingleClusterSingleContextEU, fm.SingleClusterSingleContextASIA, fm.SingleClusterSingleContextEU2, fm.SingleClusterSingleContextASIA2),
patterns: []string{"dev-eu_dev-eu*"},
expIDs: []string{"dev-eu_dev-eu-1", "dev-eu_dev-eu-2"},
expError: nil,
},
"two arguments no glob": {
fsCreator: testhelper.FSWithFiles(fm.SingleClusterSingleContextEU, fm.SingleClusterSingleContextASIA, fm.SingleClusterSingleContextEU2, fm.SingleClusterSingleContextASIA2),
patterns: []string{"dev-eu_dev-eu-1", "dev-asia_dev-asia-1"},
expIDs: []string{"dev-eu_dev-eu-1", "dev-asia_dev-asia-1"},
expError: nil,
},
"two arguments one glob": {
fsCreator: testhelper.FSWithFiles(fm.SingleClusterSingleContextEU, fm.SingleClusterSingleContextASIA, fm.SingleClusterSingleContextEU2, fm.SingleClusterSingleContextASIA2),
patterns: []string{"dev-eu_dev-eu*", "dev-asia_dev-asia-1"},
expIDs: []string{"dev-eu_dev-eu-1", "dev-eu_dev-eu-2", "dev-asia_dev-asia-1"},
expError: nil,
},
"two arguments two globs": {
fsCreator: testhelper.FSWithFiles(fm.SingleClusterSingleContextEU, fm.SingleClusterSingleContextASIA, fm.SingleClusterSingleContextEU2, fm.SingleClusterSingleContextASIA2),
patterns: []string{"dev-eu_dev-eu*", "dev-asia_dev-asia*"},
expIDs: []string{"dev-eu_dev-eu-1", "dev-eu_dev-eu-2", "dev-asia_dev-asia-1", "dev-asia_dev-asia-2"},
expError: nil,
},
"no match": {
fsCreator: testhelper.FSWithFiles(fm.SingleClusterSingleContextEU, fm.SingleClusterSingleContextASIA, fm.SingleClusterSingleContextEU2, fm.SingleClusterSingleContextASIA2),
patterns: []string{"no-match"},
expIDs: []string{},
expError: &store.NoMatch{Pattern: "no-match"},
},
}
for name, tc := range tt {
t.Run(name, func(t *testing.T) {
fsm := tc.fsCreator()
res, err := idsForGlobs(fsm, tc.patterns)
if !testhelper.EqualError(tc.expError, err) {
t.Errorf("Exp error %q, got %q", tc.expError, err)
}
var ids []string
for _, r := range res {
ids = append(ids, string(r))
}
sort.Strings(tc.expIDs)
sort.Strings(ids)
if !slices.Equal(tc.expIDs, ids) {
t.Errorf("Exp ids to be %v, got %v", tc.expIDs, ids)
}
})
}
}
func TestDelete(t *testing.T) {
selectSingleKonfCalled := 0
idsForGlobsCalled := 0
deleteKonfWithIDCalled := 0
var mockSelectSingleKonf = func(afero.Fs, prompt.RunFunc) (konf.KonfID, error) {
selectSingleKonfCalled++
return "id1", nil
}
var mockIDsForGlobs = func(afero.Fs, []string) ([]konf.KonfID, error) {
idsForGlobsCalled++
return []konf.KonfID{"id1", "id2", "id3"}, nil
}
var mockDeleteKonfWithID = func(afero.Fs, konf.KonfID) error {
deleteKonfWithIDCalled++
return nil
}
cmd := &deleteCmd{
selectSingleKonf: mockSelectSingleKonf,
idsForGlobs: mockIDsForGlobs,
deleteKonfWithID: mockDeleteKonfWithID,
}
tt := map[string]struct {
args []string
expSelectSingleKonfCalled int
expIdsForGlobsCalled int
expDeleteKonfWithIDCalled int
}{
"select one": {
args: []string{},
expSelectSingleKonfCalled: 1,
expIdsForGlobsCalled: 0,
expDeleteKonfWithIDCalled: 1,
},
"multiple arguments supplied": {
args: []string{"id1", "id2", "id3"},
expSelectSingleKonfCalled: 0,
expIdsForGlobsCalled: 1,
expDeleteKonfWithIDCalled: 3,
},
}
for name, tc := range tt {
t.Run(name, func(t *testing.T) {
selectSingleKonfCalled = 0
idsForGlobsCalled = 0
deleteKonfWithIDCalled = 0
err := cmd.delete(cmd.cmd, tc.args)
if err != nil {
t.Fatalf("An unexpected error occured: %v", err)
}
if tc.expSelectSingleKonfCalled != selectSingleKonfCalled {
t.Errorf("Exp SelectSingleKonf to be called %d times, was called %d times", tc.expSelectSingleKonfCalled, selectSingleKonfCalled)
}
if tc.expIdsForGlobsCalled != idsForGlobsCalled {
t.Errorf("Exp IDsForGlobsCalled to be called %d times, was called %d times", tc.expIdsForGlobsCalled, idsForGlobsCalled)
}
if tc.expDeleteKonfWithIDCalled != deleteKonfWithIDCalled {
t.Errorf("Exp DeleteKonfWithID to be called %d times, was called %d times", tc.expDeleteKonfWithIDCalled, deleteKonfWithIDCalled)
}
})
}
}
func TestCompleteDelete(t *testing.T) {
// since cobra takes care of the majority of the complexity (like parsing out results that don't match completion start),
// we only need to test regular cases
fm := testhelper.FilesystemManager{}
tt := map[string]struct {
fsCreator func() afero.Fs
expComp []string
expCompDirec cobra.ShellCompDirective
}{
"normal results": {
testhelper.FSWithFiles(fm.StoreDir, fm.SingleClusterSingleContextASIA, fm.SingleClusterSingleContextEU),
[]string{"dev-asia_dev-asia-1", "dev-eu_dev-eu-1"},
cobra.ShellCompDirectiveNoFileComp,
},
"no results": {
testhelper.FSWithFiles(fm.StoreDir),
[]string{},
cobra.ShellCompDirectiveNoFileComp,
},
}
for name, tc := range tt {
t.Run(name, func(t *testing.T) {
dcmd := newDeleteCommand()
dcmd.fs = tc.fsCreator()
res, compdirec := dcmd.completeDelete(dcmd.cmd, []string{}, "")
if !cmp.Equal(res, tc.expComp) {
t.Errorf("Exp and given comps differ: \n '%s'", cmp.Diff(tc.expComp, res))
}
if compdirec != tc.expCompDirec {
t.Errorf("Exp compdirec %q, got %q", tc.expCompDirec, compdirec)
}
})
}
}