8000 Remove loop over blocks of splines? · Issue #147 · QMCPACK/miniqmc · GitHub
[go: up one dir, main page]

Skip to content

Remove loop over blocks of splines? #147

Open

Description

@mdewing

The evaluation of splines is nested - one loop over blocks of splines, and an inner loop over the splines in that block. I think this was done to experiment with distributing the spline evaluation across (shared memory) processors.
This feels like an implementation detail that should not be in the base miniapp. For the base miniapp, there should be a single loop over splines.
A better way to do this is to create a spline interface, and then put the breaking of splines into blocks as one implementation behind that interface.

Activity

  1. ye-luo commented on Jul 13, 2018

    @ye-luo
    Collaborator

    This is the advantage of miniQMC over QMCPACK. There are many use of this feature for exploration.

  2. mdewing commented on Jul 13, 2018

    @mdewing
    CollaboratorAuthor

    So the nested evaluation of splines is general enough to keep in the base miniapp?

  3. ye-luo commented on Jul 13, 2018

    @ye-luo
    Collaborator

    I think this is general. In fact, thinking about splitting the walkers, this feature provide another layer of parallelism. The QMCPACK CUDA code has some similar feature although only the computing not the memory is chunked.

  4. lshulen commented on Jul 13, 2018

    @lshulen

    Regarding the loop over blocks, one nice thing about it is that it helps with cache pressure as described in the IPDPS paper (or maybe SC). It turns out to be a good feature even if you are not letting different processing elements handle different blocks.

    Arguing for the simple loop is that it will be easier for others to understand. The benefit of the loop over blocks is that it is well studied and generally turns out to be the best implementation for many platforms. I might suggest that the _ref version could have the simple loop that Mark suggests and the standard implementation retain the loop over blocks. This does imply some coupling of the data types as well, but this could also be handled easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0