[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefull stop of workers #1598

Open
Tracked by #1397
bamthomas opened this issue Nov 5, 2024 · 0 comments
Open
Tracked by #1397

Gracefull stop of workers #1598

bamthomas opened this issue Nov 5, 2024 · 0 comments
Assignees

Comments

@bamthomas
Copy link
Collaborator
bamthomas commented Nov 5, 2024

Is your feature request related to a problem? Please describe.

Until now, we used a poison pill pattern to stop workers. It is used with a blocking queue. So it is 1:1, if we have 2 workers, one worker will get the poison pill and exit, the other won't have the pill and will stay alive.

Describe the solution you'd like

We implemented a WORKER_QUEUE with AMQP for sending 1:n events (fanout/pubsub mode) from TaskManager to workers. We used it for cancelling tasks.

We could implement a similar message STOP or SHUTDOWN that would stop all workers.

It would replace the POISON objects that are used to exit the task loop.

@bamthomas bamthomas added the back label Nov 5, 2024
@bamthomas bamthomas added the bug label Nov 12, 2024
@bamthomas bamthomas moved this to Todo in Sprint 31 Nov 12, 2024
@bamthomas bamthomas self-assigned this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

1 participant