[go: up one dir, main page]

Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Add flag lifetime #46

Open
goncalossilva opened this issue Jan 24, 2022 · 2 comments
Open

Add flag lifetime #46

goncalossilva opened this issue Jan 24, 2022 · 2 comments
Labels
dashboard Specific to the dashboard documentation Improvements or additions to documentation enhancement New feature or request server Specific to the server

Comments

@goncalossilva
Copy link
Member

All flags should be created with an expected lifetime. One suggestion is 7 days for ops, 30 days for release, or custom duration.

@goncalossilva goncalossilva added documentation Improvements or additions to documentation enhancement New feature or request server Specific to the server dashboard Specific to the dashboard labels Jan 24, 2022
@kemasdimas
Copy link
Contributor

What will happen when a flag has reached its lifetime (expired)? There are 2 alternatives, either

  1. Flag will always return 1f (true), making the feature available for all users
  2. Flag will always return 0f (false), disabling the features for all users

If we decided to go with alternative 1, sunsetting a feature should be done with something like disableFeatureX that will expect 1f value to turn off the feature

@goncalossilva
Copy link
Member Author

The idea would be to notify the team via the UI (and the owner directly, if we implement #47), but not act on their behalf.

In general, a person should be making a call of what should happen with the flag. Plans get delayed, change, etc. Overall,
expected lifetimes are an aid and encouragement of best practices, but not a forcing function.

If teams really do want a forcing function, they can always wrap their rules in an if(gt(now(), datetime(<date>)), true, <rule>), haha.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dashboard Specific to the dashboard documentation Improvements or additions to documentation enhancement New feature or request server Specific to the server
Projects
None yet
Development

No branches or pull requests

2 participants