This repository has been archived by the owner on Jun 2, 2023. It is now read-only.
fix(deps): update dependency io.gitlab.arturbosch.detekt:detekt-formatting to v1.23.0 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99c7693
to
32ed899
Compare
32ed899
to
654e8dd
Compare
654e8dd
to
4940513
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.20.0->1.23.0Release Notes
detekt/detekt
v1.23.0We're so proud to announce the next upcoming stable release of detekt: 1.23.0 🚀
This release is coming with 25 new rules and much more.
We moved the detekt-compiler-plugin to the main repo, and you can now use it in your builds following the official documentation.
This release also marks the beginning of development of 2.x from the main branch! You can follow the progress here
We want to take the opportunity to thank our Sponsors and our Contributors for testing, bug reporting and helping us release this new version of Detekt. You're more than welcome to join our community on the #detekt channel on KotlinLang's Slack (you can get an invite here).
Notable Changes
detekt-compiler-plugin. The Detekt Compiler plugin is still experimental, but we're moving it closer to Detekt to make it easier to integrate. From now on the compiler plugin will follow the same versioning schema as Detekt. We invite you to try it and provide feedback till we stabilize it. You can read more about it in the official documentation page - #5492BracesOnIfStatements- #5700BracesOnWhenStatements- #5838CastNullableToNonNullableType- #5653DoubleNegativeLambda- #5937ForbiddenAnnotation- #5515PropertyUsedBeforeDeclaration- #6062StringShouldBeRawString- #5705SuspendFunSwallowedCancellation- #5666UnusedParameter- #5722UnusedPrivateProperty- #5722UseLet- #6091UnnecessaryBracesAroundTrailingLambda- #6029detekt-formattingruleset:ClassName- #6037EnumWrapping- #6028FunctionName- #6037IfElseBracing- #6028IfElseWrapping- #6028MultilineExpressionWrapping- #6028NoBlankLineInList- #6028NoConsecutiveComments- #6028NoEmptyFirstLineInClassBody- #6028NoSingleLineBlockCommentRule- #6104ParameterWrapping- #6028PropertyName- #6037PropertyWrapping- #6028StringTemplateIndent- #6028TryCatchFinallySpacing- #6028UnnecessaryAbstractClassnow only runs with type resolution - #5829UnusedPrivateMemberhas been refactored with some of its logic moved toUnusedParameterandUnusedPrivateProperty- #5722ignoreOverriddenconfig fromBooleanPropertyNaming,ConstructorParameterNaming,FunctionNaming,VariableNamingandFunctionParameterNamingas not useful for those rules - #5718ignoredSubjectTypesto ruleElseCaseInsteadOfExhaustiveWhento specify types that should be ignored by the rule (#5623) - #5634allowOperatorsto ruleDataClassContainsFunctions- #5658MandatoryBracesIfStatementshas been removed in favor ofBracesOnIfStatements- #5700ignoreWhenContainingVariableDeclarationtoUseIfInsteadOfWhento ignore captured variables - #5681detekt-formattingruleset now accepts anindentSizeparameter (see the full list here).detekt-formattingruleset are now turned on by default (see the full list here).includes/excludeslogic on the config file as they were overriding each other - #5782detekt-test-utils. The recommended testing framework is JUnit - #5785v6.8.3- #5616v8.1, AGP8.0.1, Kotlin1.8.21and KtLint0.49.1(see #5893 #5723 #5877 #6028 #6043 #5995 #5996)Changelog
commentswith a list of regexes toForbiddenComment- #5981requireRootInDeclarationcheck inInvalidPackageDeclaration- #6045detekt-versions.propertiesinstead ofversions.properties- #6006allowOmitUnitto ruleLibraryCodeMustSpecifyReturnType- #58618c8d71d- #5966Unitfor ImplicitUnitReturnType rule - #5857TestConfigusages - #5801namethat return name after backticks - #5719CanBeNonNullablerule - #5714MaxLineLength- #5583Dependency Updates
Housekeeping & Refactorings
eaaf4be- #6102dependenciesAsNames- #6059ClassNamingandFunctionNaming- #6019detekt-generator- #5854generateWebsite- #5849@Suppress("ReturnCount")- #5841timesmethod, use stdlib'srepeatinstead. - #5774Contributors
We would like to thank the following contributors that made this release possible: @3flex, @BeBAKE, @BraisGabin, @Goooler, @SaumyaBhushan, @TWiStErRob, @VitalyVPinchuk, @adef145, @asomov, @atulgpt, @chao2zhang, @cketti, @cortinico, @drawers, @dzirbel, @igorwojda, @lexa-diky, @luanpotter, @marschwar, @mjovanc, @mmorozkov, @ncteisen, @osipxd, @ov7a, @schalkms, @t-kameyama, @tresni
See all issues at: 1.23.0
v1.22.0We're extremely excited to announce the next upcoming stable release of Detekt: 1.22.0 🚀
This release is coming with 16 new rules, 2 new rulesets and several new functionalities & APIs.
We've also introduced the Detekt Marketplace, a place for users to share their 3rd party rules and extensions.
We want to take the opportunity to thank our Sponsors and our Contributors for testing, bug reporting and helping us release this new version of Detekt. You're more than welcome to join our community on the #detekt channel on KotlinLang's Slack (you can get an invite here).
Notable Changes
AlsoCouldBeApply- #5333MultilineRawStringIndentation- #5058TrimMultilineRawString- #5051UnnecessaryNotNullCheck- #5218UnnecessaryPartOfBinaryExpression- #5203UseSumOfInsteadOfFlatMapSize- #5405FunctionReturnTypeSpacingfrom KtLint - #5256FunctionSignaturefrom KtLint - #5256FunctionStartOfBodySpacingfrom KtLint - #5256NullableTypeSpacingfrom KtLint - #5256ParameterListSpacingfrom KtLint - #5256SpacingBetweenFunctionNameAndOpeningParenthesisfrom KtLint - #5256TrailingCommaOnCallSitefrom KtLint - #5312TrailingCommaOnDeclarationSitefrom KtLint - #5312TypeParameterListSpacingfrom KtLint - #5256detekt-rules-ruleauthorscontaining rules for Rule Authors to enforce best practices on Detekt rules such as the newViolatesTypeResolutionRequirements- #5129 #5182detekt-rules-librariescontaining rules mostly useful for Library Authors - We moved the following rules insideForbiddenPublicDataClass,LibraryCodeMustSpecifyReturnType,LibraryEntitiesShouldNotBePublicthis new ruleset - See Migration below on how to migrate #5360--jdk-homeCLI parameter - #5269@RequiresTypeResolutionwhen without Type Resolution - #5176checkExhaustiveness: truein your config file. This is disabled by default. - #5089--fail-fastCLI flag (andfailFastGradle property) has been removed. It was deprecated since 1.16.x - #5290DuplicateCaseInWhenExpression,MissingWhenCase,RedundantElseInWhenas the Kotlin Compiler is already reporting errors for those scenarios - #5309--print-astCLI flag as PsiViewer provides the same features - #5418ArrayPrimitiveis now working only with Type Resolution - #5175WildcardImportis now running also on tests by default - #5121ForbiddenImportallows now to specify a reason for every forbidden import - #4909IgnoredReturnValue: optionrestrictToAnnotatedMethodsis now deprecated in favor ofrestrictToConfig- #4922v7.5.1, AGP7.3.1, Kotlin1.7.21and KtLint0.47.1(see #5363 #5189 #5411 #5312 #5519)v6.7.1- #4964Migration
We deprecated a number of rules in this release.
You should update your config file as follows:
potential-bugs: active: true ... - DuplicateCaseInWhenExpression: - active: true ... - MissingWhenCase: - active: true - allowElseExpression: true ... - RedundantElseInWhen: - active: true style: active: true ... - ForbiddenPublicDataClass: - active: true - excludes: ['**'] - ignorePackages: - - '*.internal' - - '*.internal.*' ... - LibraryCodeMustSpecifyReturnType: - active: true - excludes: ['**'] ... - LibraryEntitiesShouldNotBePublic: - active: true - excludes: ['**']If you wish to use the
librariesruleset we introduced you should add the following to your config file:and add the following to you
build.gradlefile:detektPlugins("io.gitlab.arturbosch.detekt:detekt-rules-libraries:$version")If you're using our KtLint wrapper (i.e.
detekt-formatting) you should also update your config file as follows:Changelog
UnnecessaryPartOfBinaryExpression- #5514TrimMultilineRawStringfalse-positive on annotation parameters - #5476SafeCastwith no braces - #547955e685c- #5472TrailingCommaas it's now split in two rules - #5423it-started expressions - #5376FunctionOnlyReturningConstant>excludedFunctions- #5120KotlinEnvironmentResolver- #5275NestedScopeFunctions- #5274UnnecessaryAbstractClassissue description to be less verbose - #5224detektGenerateConfig- #5199ForbiddenMethodCall- #51952ca79b6- #5177RedundantExplicitTypeadd annotation@RequiresTypeResolution- #5128ExitOutsideMainifcontextBindingis empty - #5127DataClassContainsFunctions>conversionFunctionPrefix- #5119ReturnCount- #511813046b6- #5110ForbiddenMethodCall- #4910Dependency Updates
Housekeeping & Refactorings
See all issues at: 1.22.0
v1.21.0We're delighted to announce the next upcoming stable release of Detekt:
1.21.0🎉This release is coming with 6 new rules, new API and functionalities and several stability improvements.
We want to thank you very much our Sponsors for the support in those last months. The work behind Detekt is all happening on a voluntary basis, and we're more than grateful for all the support we get from the Open Source Ecosystem.
We're also excited to announce that we're now having an Open Source Gradle Enterprise instance. When building the Detekt projects, you'll benefit from the Gradle Remote Cache that this instance is providing!
Finally, we want to take the opportunity to thank our contributors for testing, bug reporting and helping
us release this new version of Detekt. You're more than welcome to join our community on the #detekt channel on KotlinLang's Slack (you can get an invite here).
Notable Changes
NullableBooleanCheck- #4872CouldBeSequence- #4855UnnecessaryBackticks- #4764ForbiddenSuppress- #4899MaxChainedCallsOnSameLine- #4985CascadingCallWrapping- #4979NestedScopeFunctions- #47881.22.0.Migration
We fixed a bug related to function with KDocs and how their location in the source code was calculated (see #4961 and #4887).
Because of this, some users might have to recreate their baseline as the location of such functions are not matched anymore against the baseline. You can do so by deleting your old baseline and invoking the
detektBaselinetask (or the corresponding task, based on your configuration).Changelog
Configuration
📅 Schedule: Branch creation - "every weekday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.