8000 chore: repo-wide Actions hardening, dependabot for action pins, gitignore .DS_Store · Issue #35 · Altinity/altinity-oauth-helper · GitHub
[go: up one dir, main page]

Skip to content

chore: repo-wide Actions hardening, dependabot for action pins, gitignore .DS_Store #35

Closed

Description

@BorisTyshkevich

Out of scope for #23, deliberately deferred while shipping the PR-time gate. Three small
repository-hygiene items, all discovered during that work.

1. Repo-wide Actions defaults are broader than any workflow needs

gh api repos/{owner}/{repo}/actions/permissions/workflow currently reports:

  • default_workflow_permissions: "write"
  • can_approve_pull_request_reviews: true

Both should be tightened to read / false.

This is defence in depth, not a fix for anything: a PR author with write access can
override permissions: in a workflow anyway, and .github/workflows/pr-gate.yml already
declares contents: read explicitly — which is precisely why that explicit block is
load-bearing rather than decorative today. The benefit is that a future workflow which
forgets its own permissions: inherits a safe default instead of a write token, and that
Actions can no longer approve pull requests (GitHub documents that capability as
security-sensitive).

Check the two image-publication workflows before flipping: both already declare their own
permissions: (contents: read + packages: write), so the expected compatibility risk
is low, but confirm rather than assume.

2. No github-actions ecosystem in .github/dependabot.yml

.github/workflows/pr-gate.yml pins actions/checkout and actions/setup-go to full
commit SHAs. Nothing will ever bump them, so they will silently go stale — and #23 shipped
specifically because stale pins matter: its original pins declared the node20 runtime,
which GitHub removes from runner images on 2026-09-23, so the brand-new gate would have
broken about three weeks after landing.

Adding a github-actions ecosystem to .github/dependabot.yml would surface those bumps
as PRs. Note internal/securitytest/pr_gate_contract_test.go enforces a node24 floor
on each pin's trailing # <identity>@vX.Y.Z comment (actions/checkout >= v5.0.0,
actions/setup-go >= v6.2.0), so a Dependabot PR must update the comment alongside the
SHA or that test fails — which is the intended behaviour, but worth knowing before wiring
it up.

3. .DS_Store is untracked and not gitignored

It sits in the working tree on macOS and is one git add -A away from being committed.
One line in .gitignore.

Each of these is independent; they are grouped only because they are all small and were
all found while shipping #23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0