8000 Post-wizard Ollama validation before session start · Issue #53 · ARPAHLS/rooms · GitHub
[go: up one dir, main page]

Skip to content

Post-wizard Ollama validation before session start #53

Description

@rosspeili

Problem Statement

After #43, users get early Ollama checks for YAML defaults only. The interactive wizard lets users invite custom agents and set orchestrator models interactively. Those models are not validated before run_session() starts, so users still hit LiteLLM/Ollama errors mid-session after passing startup preflight (especially with --skip-preflight or non-Ollama defaults + Ollama custom agents).

Proposed Solution

  1. After wizard builds active_agent_configs (+ optional orchestrator), collect all ollama/… models from the final session config.

  2. Reuse shared Ollama helper (issue feat: add timeout to Agent.generate_response() #2) to verify tags once before run_session().

  3. On failure: print the same actionable panel as preflight; offer to return to wizard, edit model strings, or abort (do not start session with known-bad tags).

  4. Respect --skip-preflight for both startup and post-wizard checks (or document --skip-preflight as global bypass).

  5. Smoke test: mock validation hook; assert called with wizard-built configs.

Acceptance criteria

  • Custom agent with missing Ollama tag blocked before first turn
  • Orchestrator chosen in wizard validated even when YAML default is non-Ollama
  • --skip-preflight bypasses both checks
  • No duplicate /api/tags calls when tags unchanged from startup check

Alternatives Considered

Priority

Medium 🟡

Additional Context

No response

Activity

  1. added theissue type on Jun 9, 2026
  2. added
    cliImprovements to the interactive wizard or terminal output.
    on Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cliImprovements to the interactive wizard or terminal output.enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0