8000 Merging the app-live lane breaks the bounded session-sync failure test · Issue #162 · shroominic/OpenGlucose · GitHub
[go: up one dir, main page]

Skip to content

Merging the app-live lane breaks the bounded session-sync failure test #162

Open

Description

@shroominic

What breaks

openhealth/test/session_sync_failure_test.dart fails when the app-live lane is merged into the
sensor aggregate:

❌ an undecodable frame followed by silence fails closed
Expected: exactly one matching candidate
  Actual: _TextWidgetFinder:<Found 0 widgets with text "Syncing sensor history": []>

Evidence

Tree Command Result
origin/release/v0.4.0 (7541552, before the lane append) flutter test --no-pub test/session_sync_failure_test.dart exit 0, +5: All tests passed!
append branch = release/v0.4.0 + #142 (feature/cbio-gs1-app-live) + #144 same command exit 1, +4 -1: Some tests failed.
append branch, full make test-unit - 487 passed, 1 failed (this test only)

So this is a cross-lane interaction, not a pre-existing failure: #134 (fix/session-sync-bounded-failure,
issue #133) owns that contract, and #142 changes the app surface it renders against.

Why it matters

The failing test is the guard for the bounded-failure contract on issue #133: a session that never
decodes must fail closed and surface the sync state, not hang. A release aggregate that merges the
sensor lanes and silently drops that guard cannot claim the bounded-failure fix works in the shipped
combination, even though each lane is individually green.

Next step

Decide which side moves: whether the app-live surface still renders the sync stage that #133 depends
on, or whether the sync-failure test's expectation changed legitimately with the new app path. The
fix belongs on the lane that owns the changed surface, with the other lane's test kept intact.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0