Repository navigation
Replies: 1 comment
|
From what's public on the PR and the issue, you've already pinged the right people. Here's how the routing works:
On regression coverage, two things reviewers will probably ask about:
The other points from CONTRIBUTING also apply. New contributors can have at most 2 open PRs, and PRs can be closed if feedback isn't answered within 2 weeks, so keep an eye on notifications once review starts. Hope that helps you get it moving. If it answers your question, feel free to mark it as the answer. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hi all — could someone point me to the appropriate reviewer for the username-validation / LDAP federation area?
I have a small fix in #53514 for #52215. It prevents an unchanged, case-preserved LDAP username from being rejected as a username mutation when the username is read-only. The change is limited to the validator and a regression test (two files, one commit).
The fork validation is linked from the PR; upstream workflows are awaiting maintainer approval. I would appreciate guidance on who owns this path, and whether any additional regression coverage is needed before review.
I understand the review queue is large — this is a routing question, not a request to bypass normal review. Happy to address feedback. Thanks!
All reactions