You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Inconsistency in class DefaultEmailSenderProvider
#42272
First of all, I apologize if this is not the right place for opening such topic.
I think I may have found an inconsistency in Class org.keycloak.email.DefaultEmailSenderProvider.java in Kecloak 26.3.3. This inconsistency is still present in latest as of now.
Line 260 to 265 have this code:
final String covertedFrom = convertEmail(from, allowutf8);
if (from ==null)
{
throw new ...
}
return covertedFrom
Although I think the code should be
final String convertedFrom = convertEmail(from, allowutf8);
if (convertedFrom ==null)
{
throw new ...
}
return convertedFrom
Since the purpose of the function and the test it includes is to check that the from address can be converted and return the converted address, as it is done with user address in method "checkUserAddress" at line 251.
I have not found how to suggest that through Issue Opening and I would like to know if my analysis is correct and in the latter case if it is worth submitting a PR.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Hello,
First of all, I apologize if this is not the right place for opening such topic.
I think I may have found an inconsistency in Class org.keycloak.email.DefaultEmailSenderProvider.java in Kecloak 26.3.3. This inconsistency is still present in latest as of now.
Line 260 to 265 have this code:
Although I think the code should be
Since the purpose of the function and the test it includes is to check that the from address can be converted and return the converted address, as it is done with user address in method "checkUserAddress" at line 251.
I have not found how to suggest that through Issue Opening and I would like to know if my analysis is correct and in the latter case if it is worth submitting a PR.
Thank you
All reactions