Repository navigation
Replies: 2 comments
|
My two cents: Code formattingEasier and consistent code formatting with a tool like spotless would be great, but when to fix existing formatting? I see at least these options, which both have their advantages and disadvantages:
Static Code AnalysisI think Sonar is free for OS projects and is probably the most used "all-in-one static analysis tool". We are using it at Bosch and it works quite well for us (Java, JS, TS code). On more advanced toolsI don't have personal experience with Pitest and OpenRewrite, but think those could be useful. But I'd priorize having consistent Code formatting and Static code analysis. |
|
We'll be starting first steps in #43232 which will be incremental and focused on the developer experience. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Subject: Enhancing Code Quality and Consistency with Static Analysis Tools
Facing a significant number of corruptions and inconsistencies in the codebase, it makes me wonder about the current level of control over the code quality. Is the current state more of a de facto standard, reliant on chaos, luck, or accident?
Assuming that best practices and common development principles are also beneficial for Keycloak, I'm curious about the current strategy. Other major open-source projects heavily utilize a suite of static code analysis tools to maintain hygiene and prevent bugs:
This is not just a theoretical concern. We can see concrete examples of issues that could be caught or prevented by such tools:
errorprone.refasterrulescheckstyle/checkstyle#17760Rewrite:UpgradeToJava17checkstyle/checkstyle#17730I would like to discuss the potential of integrating such a toolchain into the Keycloak build process. It could significantly reduce trivial noise, prevent a class of bugs from being introduced, and make the contribution process smoother by automatically enforcing a consistent code style.
What are the community's thoughts on this?
All reactions