You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Follow-ups from #3482: resume refusals that lost their next step, docs scope, and two weak tests #3507
Low-severity points left open on #3482 at e49b92b4. None blocks the merge.
Some resume refusals lost their next step.crates/minimal-client/src/attach.rs (about 914) makes every refusal in minvmd's "could not give the box an address: " family fatal, not only the DNS service case. A refusal because the address range is full, or because the address is quarantined, now ends the command with the bare reason. Before, it reached the guest's BoxHostRowEnded, whose "run the same command again" is the right step for a quarantine that clears. Make only the reasons that name a command fatal, or give each one a step the user can run.
The docs overstate.docs/reference/cli-min.md (about 311-313) says the reason names the command that checks the setup. That holds only for the DNS service case. The paragraph covers attach only, but min box exec and min session exec (exec.rs, about 348) fail on the same refusal with exit 1 and are not mentioned.
A copied reason.NO_ANSWERER's text is copied by hand in box_registration.rs (about 1038) and vm_host.rs (about 1500). Nothing fails when minvmd's text in crates/minvmd/src/net/answerer.rs changes. Read it from the source, as the prefix test does.
Activity