8000 Follow-ups from #3481: the failing DNS service line can name the wrong holder; install.sh comment placement · Issue #3497 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

Follow-ups from #3481: the failing DNS service line can name the wrong holder; install.sh comment placement #3497

Open

Description

@norrietaylor

Two low-severity findings from minimal-review on #3481 at 4f0583ce, left open when the PR merged. The coder's round for them could not push while the PR sat in the merge queue.

  1. The failing-service line can blame the wrong program. vm_host_answerer_line_beside (crates/minimal/src/resolver.rs, about line 5114) says that Minimal's DNS service holds the port and is not running whenever the port is held with no channel and the service's job reads as not running. It never checks who holds the port. A unit can fail because another program already holds 127.0.0.1:7656. The line then names Minimal's service as the holder and suggests a reinstall that cannot free the port. Check the holder, or word the line so that it does not claim one.
  2. A misplaced shell function. In scripts/install.sh, the new answerer_copy_differs function sits between the long doc comment of offer_finalize_install and that function. The comment now reads as if it documents answerer_copy_differs. Move the function and its own comment above offer_finalize_install's comment.

Activity

  1. norrietaylor commented on Nov 17, 2026

    @norrietaylor
    MemberAuthor

    One more, from #3484 at c574c369: when the log directory exists but fails the step's ownership checks (for example, someone changes its owner after install), the min bug skip for a missing minzoned log says the service creates the file when it next starts (crates/minimal/src/diag/answerer.rs, about 316-330). In that state min finalize-install has work to do, so the skip should name it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpriority:nice-to-haveNice to have. Applied by the inbox-route classifier or a human.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0